vwemirror/BT411
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Revert the key G action ModeCycle default -- F7 already does it, on both keymaps

Browse Source 
c1a87b6 added G on the premise that a keyboard-only player could not reach the
control mode.  That premise was WRONG, caught by the operator: I checked only
for `action ModeCycle` verbs and missed the CONSOLE BUTTON route.

    content/bindings.txt:147   key F7 button 0x18
    content/CONTROLS.MAP:136   key F7 button 0x18

0x18 IS CycleControlMode (context/pod-hardware.md:69), and it is wired:
MESSAGE_ENTRY(MechControlsMapper, CycleControlMode) ->
CycleControlModeMessageHandler -> CycleControlModeNow -- the same body the
gamepad Start and the pod console button drive.  So F7 has always cycled the
mode from the keyboard, on BOTH keymaps.  Every console button really is mapped.

Worse than redundant: CONTROLS.MAP:172 already binds `key G action Flush`, so
shipping G=ModeCycle in the glass default board would have made G mean different
things on the pod and on glass -- two populations with two sets of muscle memory,
which is precisely what the bindings-board migration exists to prevent.

Reverted from the shipped default template and from the local bindings.txt.
The torso-twist verification stands: the operator cycled modes and confirmed the
fix live; only the key used to do it was needlessly new.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018SgmXGNMXavXiafKXf9MDC
This commit is contained in:
Joe DiPrima
2026-08-08 17:48:57 -05:00
co-authored by Claude Opus 5
parent 06d3b93507
commit 0961a0b3f3
1 changed files with 0 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
engine/MUNGA_L4/L4PADBINDINGS.cpp
-7
View File
@@ -302,13 +302,6 @@ static const char *defaultProfileText =
"key LEFT button 0x44 # look left\n"
"key RIGHT button 0x43 # look right\n"
"\n"
"# --- CONTROL MODE cycle (Basic -> Standard -> Veteran -> Basic) --------\n"
"# The pod cycles this from a console button and CONTROLS.MAP binds it only to\n"
"# the gamepad Start, so a KEYBOARD-ONLY player had no way to reach it at all.\n"
"# Basic: stick steers, torso auto-centres. Standard/Veteran: stick TWISTS the\n"
"# torso and the PEDALS steer (NUMPAD7/9). G is free; M is keypad button 0x02.\n"
"key G action ModeCycle\n"
"\n"
"# --- UPPER MFD banks: number row on top, QWERTY beneath ----------------\n"
"# Heat / coolant (0x28-0x2F) -- 1-4 and QWER ARE the coolant system:\n"
"# 1/2/3 Condenser 1-3 valve, 4 coolant FLUSH (hold), Q/W/E Condenser\n"