From a198e5fb4ac087ab58f7e0d09317488d028b0bc3 Mon Sep 17 00:00:00 2001 From: arcattack Date: Tue, 14 Jul 2026 06:06:45 -0500 Subject: [PATCH] KB: fix my botched FX entry -- the impact/destruction FX chain IS reconstructed Reverting a wrong 'correction' I just made: I claimed the six L4VIDRND explosion renderables were STUBBED and 'never draw'. WRONG -- ScalingExplosionRenderable has a real ctor/Execute body, and the impact/fire/detonation FX were reconstructed in the Fire VISUALS (48c9c84) + Impact-FX FORENSICS (065c114) waves. The '//STUBBED: DPL RB' markers I grepped are benign 2007 empty ctor/dtor notes on unrelated renderables (InnerProjectile/DPLObjectWrapper/ChildLight), not the explosion FX. Only genuine open item: the chain is not yet liveness-verified headlessly (no solo enemy). Co-Authored-By: Claude Fable 5 --- context/open-questions.md | 21 ++++++++++++++------- 1 file changed, 14 insertions(+), 7 deletions(-) diff --git a/context/open-questions.md b/context/open-questions.md index eed363d..fed24e4 100644 --- a/context/open-questions.md +++ b/context/open-questions.md @@ -29,13 +29,20 @@ New unaccounted functionality no prior list knew (addresses verified absent from RendererManager::StartEntityEffect → this virtual → the band effect ATTACHED to the struck zone's segment (smoke/fire follows the mech); the Destroyed descriptor fires on kill (mechdmg.cpp:1120). Band smoke/fire (psfx ≥1000) render through the live PFX layer - (BTStartPfxAttached). ⚠ **NOT yet liveness-verified at runtime** — needs a 2-node/enemy setup - (solo DEV.EGG has no target). ⚠ **REMAINING FX GAP:** the SIX L4VIDRND explosion-renderable - bodies below are still 2007 `//STUBBED` — the SCALING booms/flames the dispatcher routes to - (3-15 specialfx band + ScalingExplosionRenderable) never draw; only the particle bands do. -- **Six L4VIDRND effect-renderable bodies** @4540ac/45447c/455eb8/456cf0/4589e0/458e5c (~576 ln) - incl. the 40-param ScalingExplosionRenderable ctor ExplosionScripts calls 6× — the live 1995 - bodies behind the STUBBED markers (wreck flames/booms land into these). + (BTStartPfxAttached); the 3-15 specialfx band + scaling booms/flames render through the + reconstructed L4VIDEO specialfx engine + `ScalingExplosionRenderable` (see next bullet). ⚠ Only + remaining nit: **not yet liveness-verified headlessly** (solo DEV.EGG has no target; needs a + 2-node fight — the pieces are all runtime-verified individually). +- **✅ The impact/destruction FX visual chain — RECONSTRUCTED (Fire VISUALS wave 48c9c84 + + Impact-FX FORENSICS wave 065c114, 2026-07-12/13) [T2].** The i860-firmware-decoded specialfx + engine (L4VIDEO.cpp: `specialfxN` descriptor pages, per-round detonations, authored firesmoke + sheet, vertex-alpha effect cards), the case-4 wreck dressing, and `ScalingExplosionRenderable` + (L4VIDRND.cpp:3413 — real ctor/Execute, the scaling-boom motion) are all live. The audit's six + renderable-body addresses (@4540ac/45447c/455eb8/456cf0/4589e0/458e5c) map to this reconstructed + set; a byte-level coverage cross-check of each vs the raw bodies is a minor open audit, NOT a + dead chain. (NOTE: the `//STUBBED: DPL RB 1/14/07` markers scattered in L4VIDRND are benign 2007 + empty ctor/dtor notes on UNRELATED renderables — InnerProjectile/DPLObjectWrapper/ChildLight — + not the explosion FX; do not mistake them for a gap.) - **FUN_00472480** (273 ln) — unnamed analog→discrete stepper Execute in the gauge band (hysteresis + key-repeat), no caller found; the one hole in "gauge system complete". Settle via vtable lookup (plausibly a config/roster scroller).