vwemirror/BT412
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Audio: footsteps arrive on the FIRST stride -- the 10-20 s warm-up bug

Browse Source 
User report: footfalls silent for the first 10-20 s of every mission (all
mechs), then solid.  Root cause was three interlocking layers, each measured
with timestamped traces:

1. The authored footstep volume chain (LocalAcceleration [0,10]->ctl100 +
   LocalVelocity [0,0.6]->ctl101 through authored N=30/N=15
   AudioControlSmoothers, fill 0) hangs off the SOURCE's watcher chain
   (scale watches smoother watches mixer watches source), and an idle
   source's chain executes only at Start attempts -- one smoother sample
   per stride.
2. Each hop is frame-gated (AudioComponent::ExecuteWatchers,
   DefaultAudioFrameDelay), so any burst collapses to one execution.
3. The transient drop gate (vol < 0.3, AUDREND) rejected every Start while
   the smoother average crawled up 1/30th per attempt -> ~25 dropped strides
   before the first audible step, then per-frame execution while playing
   kept it warm forever ("solid after that").

Fixes (engine-level, each documented in place):
- AudioScaleOf<T>::Execute now sends EVERY poll (scales are continuous
  value-feeders; the base bitwise change-gate -- Motion::operator== is
  memcmp -- froze on our deterministic gait math, where the original's
  noisy physics floats never bit-repeated.  Triggers/matchers keep the
  change gate: their semantics are edge-based).
- Component/AudioComponent::PrimeWatchers(passes): recursive, GATE-FREE
  watcher pump; AUDREND runs 30 passes on every transient Start request so
  the authored smoothers evaluate at their true steady state before the
  drop gate reads the volume.
- localAcceleration derives via the binary's exact structure: 15-sample
  ring buffers of the raw position derivative + dt (ctor part_012.c:9836,
  derive :15169-15195), in the PerformAndWatch tail so it runs every frame.
- AttributeWatcherOf::GrabCurrentValue private -> protected (the scale
  override calls it).

Verified (30 s walk from cold start): drops 25 -> 3 (the survivors are
authentic quiet-stride gating: first gentle strides at vol ~0.28 vs the 0.3
gate), footfalls deliver from the first stride, 43 delivered with live
per-stride gain variation.  Diag traces added: [accwatch]/[fsscale]/
[smooth]/[smoothcfg]/[motionscalecfg] + timestamps on DROP/volset.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
arcattack
2026-07-16 15:11:17 -05:00
co-authored by Claude Opus 4.8
parent a8f14e1c24
commit a11a697824
11 changed files with 202 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files
engine/MUNGA/AUDCMP.cpp
+13
View File
@@ -856,6 +856,11 @@ AudioControlSmoother::AudioControlSmoother(
MemoryStream_Read(stream, &initial_fill_value);
audioControlAverage.SetSize(number_of_samples, initial_fill_value);
if (getenv("BT_ATTRBIND_LOG")) { static int s_sm=0; if (s_sm++<40)
DEBUG_STREAM << "[smoothcfg] this=" << (void*)this << " ctlID=" << (int)control_ID
<< " samples=" << (int)number_of_samples << " fill=" << initial_fill_value
<< "\n" << std::flush; }
AudioControlSmootherX(
audio_component,
entity,
@@ -955,6 +960,14 @@ void
{
audioControlAverage.Add(control_value);
if (getenv("BT_AUDIO_SPATIAL")) { static int s_sa=0;
if ((controlID == 100 || controlID == 101) && s_sa++ < 3000)
DEBUG_STREAM << "[smooth] t=" << (GetTickCount() % 1000000)
<< " this=" << (void*)this << " ctl=" << (int)controlID
<< " in=" << control_value
<< " avg=" << audioControlAverage.CalculateOlympicAverage()
<< "\n" << std::flush; }
Check(audioComponentSocket.GetCurrent());
audioComponentSocket.GetCurrent()->ReceiveControl(
controlID,
engine/MUNGA/AUDIO.cpp
+23
View File
@@ -463,6 +463,29 @@ void
}
}
//
//#############################################################################
//#############################################################################
//
void
AudioComponent::PrimeWatchers(int passes)
{
Check(this);
for (int pass = 0; pass < passes; ++pass)
{
ChainIteratorOf<Component*> iterator(&audioWatcherSocket);
Component *component;
while ((component = iterator.ReadAndNext()) != NULL)
{
Check(component);
// recurse gate-free: an AudioComponent child (mixer/smoother/
// splitter) pumps ITS chain; an attribute watcher re-reads +
// re-sends. One pass per level keeps total work = passes x chain.
component->PrimeWatchers(1);
}
}
}
//
//#############################################################################
//#############################################################################
engine/MUNGA/AUDIO.h
+8
View File
@@ -454,6 +454,14 @@ public:
void
ExecuteWatchers();
// (task #50, AUDIO_FIDELITY F19) gate-free watcher pump for the transient
// cold-start prime: ExecuteWatchers above is frame-gated
// (DefaultAudioFrameDelay), so N calls in one tick collapse to one.
// Recurses through the watcher CHAIN (source <- mixer <- smoother <-
// scale), each hop gate-free.
virtual void
PrimeWatchers(int passes);
void
Execute();
engine/MUNGA/AUDREND.cpp
+15 -1
View File
@@ -194,6 +194,19 @@ void
else
{
audio_source_priority = audio_source->GetAudioSourcePriority();
// (task #50, AUDIO_FIDELITY F19) COLD-START PRIME: an idle source's own
// watcher socket only executes at Start attempts, so its authored
// AudioControlSmoothers (footstep volume: N=30/15, fill 0) warmed ONE
// sample per attempt -- and the transient drop gate below (vol < 0.3)
// rejected the first ~25 footfalls (~10-20 s of silent steps) before
// the average could cross the gate. On a Start request, pump the
// source's watchers a full smoother window so the volume chain is
// evaluated at its true steady state; the smoother keeps its authored
// smoothing role for live variation once the source is playing.
if (message->controlID == StartAudioControlID)
{
audio_source->PrimeWatchers(30);
}
audio_source_volume_scale = audio_source->CalculateSourceVolumeScale();
if (getenv("BT_AUDIO_SPATIAL")) { static int s_vs=0; if ((s_vs++ % 120)==0)
DEBUG_STREAM << "[spatial] request src=" << (void*)audio_source
@@ -227,7 +240,8 @@ void
)
{
if (getenv("BT_AUDIO_SPATIAL")) { static int s_dr=0; if (s_dr++<40)
DEBUG_STREAM << "[spatial] DROP transient start src=" << (void*)audio_source
DEBUG_STREAM << "[spatial] DROP transient start t=" << (GetTickCount() % 1000000)
<< " src=" << (void*)audio_source
<< " vol=" << audio_source_volume_scale
<< " (below threshold " << LowAudioVolumeThreshold << ")\n" << std::flush; }
#ifdef LAB_ONLY
engine/MUNGA/AUDWTHR.h
+31
View File
@@ -445,6 +445,30 @@ public:
);
~AudioScaleOf();
//
//--------------------------------------------------------------------
// Execute -- scales send EVERY poll (task #50, AUDIO_FIDELITY F19).
//
// The base watcher gate is a BITWISE compare (Motion::operator== is
// memcmp) that existed to skip truly static values. In the original,
// scale-watched attributes (velocities, accelerations, temperatures)
// were noisy physics floats that practically changed every poll, so
// scales streamed per-poll values into their authored consumers -- the
// footstep AudioControlSmoothers (N=30/15, fill 0) are SIZED for that
// cadence. Our reconstruction's math can be deterministic (the gait
// integrator lands on bit-identical derived values during smooth
// acceleration), which froze the gate and starved the smoothers (the
// 10-20 s footstep warm-up). Sending unconditionally restores the
// original's practical behavior; triggers/matchers keep the change
// gate (their semantics are edge-based).
//--------------------------------------------------------------------
//
void
Execute()
{
GrabCurrentValue();
}
//
//--------------------------------------------------------------------
// BuildFromPage
@@ -648,6 +672,13 @@ template <class T> void
if (getenv("BT_AUDIO_SPATIAL") && control_value <= 0.0f) {
static int s_sc=0; if (s_sc++<400)
DEBUG_STREAM << "[spatial] scale->0 attrPtr=" << (void*)attributePointer << " comp=" << (void*)audioComponentSocket.GetCurrent() << " raw=" << current_value << " ctlID=" << (int)controlID << " ctl=" << control_value << " aB=[" << attributeValueBoundary1 << "," << attributeValueBoundary2 << "]" << " cB=[" << controlValueBoundary1 << "," << controlValueBoundary2 << "]\n" << std::flush; }
if (getenv("BT_AUDIO_SPATIAL") && (controlID == 100 || controlID == 101)) {
static int s_fs2=0; if (s_fs2++<2000)
DEBUG_STREAM << "[fsscale] t=" << (GetTickCount() % 1000000)
<< " attrPtr=" << (void*)attributePointer
<< " comp=" << (void*)audioComponentSocket.GetCurrent()
<< " ctl" << (int)controlID << " raw=" << current_value
<< " out=" << control_value << "\n" << std::flush; }
audioComponentSocket.GetCurrent()->ReceiveControl(
controlID,
control_value
engine/MUNGA/CMPNNT.h
+11
View File
@@ -11,6 +11,17 @@ public:
virtual void Execute();
// (task #50, AUDIO_FIDELITY F19) gate-free watcher pump for the audio
// transient cold-start prime. Default: run Execute() N times (attribute
// watchers re-read + re-send each pass). AudioComponent overrides it to
// RECURSE through its watcher chain, bypassing the per-component
// audio-frame gate that otherwise collapses the passes to one.
virtual void PrimeWatchers(int passes)
{
for (int pass = 0; pass < passes; ++pass)
Execute();
}
static Derivation *GetClassDerivations();
static SharedData DefaultData;
engine/MUNGA/WATCHER.h
+16 -1
View File
@@ -156,14 +156,18 @@ private:
void
InitializeCurrentValue();
protected:
//
//-----------------------------------------------------------------------
// GrabCurrentValue
// GrabCurrentValue -- protected (task #50): AudioScaleOf's per-poll
// Execute override calls it directly (see AUDWTHR.h).
//-----------------------------------------------------------------------
//
void
GrabCurrentValue();
private:
//
//-----------------------------------------------------------------------
// DumpValue
@@ -273,6 +277,17 @@ template <class T> void
DEBUG_STREAM << "[fswatch] poll#" << s_fsp << " cur=" << (int)*(int*)&currentValue
<< " mem=" << *(int*)attributePointer << "\n" << std::flush;
}
extern void *g_btAccelAddr; // DIAG: poll-vs-change split on the accel attr
if ((void*)attributePointer == g_btAccelAddr) {
static long s_ap=0, s_ac=0;
int changed = !(currentValue == *(T*)attributePointer);
if (changed) ++s_ac;
if ((++s_ap % 120)==0 || (changed && (s_ac % 30)==0))
DEBUG_STREAM << "[accwatch] t=" << (GetTickCount() % 1000000)
<< " poll#" << s_ap << " changes=" << s_ac
<< " memY=" << ((float*)attributePointer)[1]
<< " curY=" << ((float*)&currentValue)[1] << "\n" << std::flush;
}
}
if (!(currentValue == *(T*)attributePointer))
{