arcattackandClaude Opus 4.8
2bcca26cea
An 8-agent decomp-mapping workflow mapped every weapon-family ctor + fire/spawn path
(scratchpad/wave7_maps.txt). KEY IDENTITY CORRECTION via VDATA.h enum (base 3000=0xBB8):
the factory ctor-address comments were right but the built CLASS names were stubs/base --
0xBCD == ProjectileWeapon (was building the base MechWeapon stub)
0xBCE == GaussRifle (NOT MissileLauncher -- was a MissileLauncher stub)
0xBD0 == MissileLauncher (NOT BallisticWeapon -- was a BallisticWeapon stub)
Un-mislabeled + wired via Create<Class>Subsystem bridges (mirroring CreateEmitterSubsystem),
each static_assert-locked byte-exact on the now-locked MechWeapon(0x3F0)/Emitter(0x478) bases:
* ProjectileWeapon (0xBCD, @4bc3fc : MechWeapon, sizeof 0x448)
FIX: AmmoBinConnection was an empty 1-byte struct -> retyped to the binary's 0xC
SharedData::Connection (was making the object 8 bytes short, sliding
MissileLauncher's missileCount off 0x448).
* MissileLauncher (0xBD0, @4bcff0 : ProjectileWeapon, sizeof 0x44C)
FIX: deleted muzzleVelocity (ALIAS of inherited ProjectileWeapon launchVelocity@0x410)
and salvoCount (SHADOW of inherited MechWeapon damageData.burstCount@0x3d4),
keeping the single own field missileCount@0x448.
* GaussRifle (0xBCE, @4bdcb4 : Emitter, sizeof 0x484 = Emitter + Vector3D muzzleVelocity)
DEDICATED bridge (not CreateEmitter): its FireWeapon is a no-op (mov [eax+0x414],0) --
a non-functional weapon in this 1995 build. Also fixed GAUSS.CPP's discharge write
rechargeLevel -> currentLevel@0x414 (the binary writes this+0x414).
Phase A safe-stubs FireWeapon (consume round + recoil, NO spawn): the reconstructed
Projectile (@4be1bc, 0x340) + Missile (@4bf5b4, 0x368) ENTITY classes are NOT spawn-ready
(Entity-base phantom members overflow their New() alloc -> heap corruption; New() takes
(int)this instead of the 0xD4 descriptor; Entity base size unconfirmed 2007-vs-1995, the
Mech 0x638-vs-0x854 problem). The workflow's adversarial verify flagged the live spawn as a
heap-overflow hazard and recommended exactly this phasing. Phase B = the entity byte-exactness
+ descriptor build + New(MakeMessage*) so a fired shot becomes a flying entity that damages.
Factory now 18 of 20 cases wired to real ticking classes (remaining: SubsystemMessageManager
0xBD3 [WAVE 8], Gyroscope 0xBC4 [deferred]). Verified: Mad Cat (LRM/ballistic) + BLH construct
the real weapon classes + tick authentic charge/ammo/heat/recoil, DESTROYED-in-8, 0 crashes,
heapcheck-clean through construction. Energy weapons already damage via the mech4 beam path,
so combat is unaffected.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
151 lines
4.3 KiB
C++
151 lines
4.3 KiB
C++
//===========================================================================//
|
|
// File: gauss.hh //
|
|
// Project: BT Brick: Entity Manager //
|
|
// Contents: Gauss Rifle class, derives from Projectile Weapon //
|
|
//---------------------------------------------------------------------------//
|
|
// Date Who Modification //
|
|
// -------- --- ---------------------------------------------------------- //
|
|
// 04/13/95 JM Initial coding. //
|
|
// 07/19/95 GDU Complied to new munga, added new electrical behavior //
|
|
//---------------------------------------------------------------------------//
|
|
// Copyright (C) 1995, Virtual World Entertainment, Inc. All Rights reserved //
|
|
// //
|
|
// PROPRIETARY AND CONFIDENTIAL //
|
|
//===========================================================================//
|
|
|
|
#if !defined (GAUSS_HPP)
|
|
#define GAUSS_HPP
|
|
|
|
#if !defined(EMITTER_HPP)
|
|
# include <emitter.hpp>
|
|
#endif
|
|
|
|
|
|
//##################### Forward Class Declarations #######################
|
|
class Mech;
|
|
class Projectile;
|
|
|
|
//###########################################################################
|
|
//######################### GaussRifle Model Resource ########################
|
|
//###########################################################################
|
|
struct GaussRifle__SubsystemResource:
|
|
public Emitter::SubsystemResource
|
|
{
|
|
Scalar dischargeVoltage;
|
|
};
|
|
//###########################################################################
|
|
//######################### CLASS -- GaussRifle ##########################
|
|
//###########################################################################
|
|
class GaussRifle : public Emitter
|
|
{
|
|
|
|
//~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|
|
// Shared Data Support
|
|
//
|
|
public:
|
|
static Derivation ClassDerivations;
|
|
static SharedData DefaultData;
|
|
|
|
//~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|
|
// Messageing Support
|
|
//
|
|
|
|
#if 0
|
|
//##########################################################################
|
|
// Attribute Support
|
|
//
|
|
public:
|
|
|
|
enum {
|
|
= Emitter::NextAttributeID,
|
|
NextAttributeID
|
|
};
|
|
|
|
private:
|
|
static const IndexEntry AttributePointers[];
|
|
|
|
public:
|
|
static AttributeIndexSet AttributeIndex;
|
|
#endif
|
|
|
|
//##########################################################################
|
|
// Model Support
|
|
//
|
|
public:
|
|
|
|
|
|
typedef void
|
|
(GaussRifle::*Performance)(Scalar time_slice);
|
|
|
|
void
|
|
SetPerformance(Performance performance)
|
|
{
|
|
Check(this);
|
|
activePerformance = (Simulation::Performance)performance;
|
|
}
|
|
|
|
void
|
|
GaussRifleSimulation(Scalar time_slice);
|
|
|
|
//##########################################################################
|
|
// TestClass Support
|
|
//
|
|
public:
|
|
|
|
static Logical
|
|
TestClass(Mech &);
|
|
void
|
|
ResetToInitialState();
|
|
|
|
//##########################################################################
|
|
// Construction and Destruction
|
|
//
|
|
public:
|
|
typedef GaussRifle__SubsystemResource SubsystemResource;
|
|
|
|
GaussRifle(
|
|
Mech *owner,
|
|
int subsystem_ID,
|
|
SubsystemResource *subsystem_resource,
|
|
SharedData &shared_data=DefaultData
|
|
);
|
|
~GaussRifle();
|
|
|
|
Logical
|
|
TestInstance() const;
|
|
|
|
static int
|
|
CreateStreamedSubsystem(
|
|
ResourceFile *resource_file,
|
|
NotationFile *model_file,
|
|
const char *model_name,
|
|
const char *subsystem_name,
|
|
SubsystemResource *subsystem_resource,
|
|
NotationFile *subsystem_file,
|
|
const ResourceDirectories *directories,
|
|
int passes =1
|
|
);
|
|
|
|
//~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|
|
// Local data for the gun class
|
|
//
|
|
|
|
protected:
|
|
|
|
void
|
|
FireWeapon();
|
|
|
|
Vector3D
|
|
muzzleVelocity; // @0x478 (past Emitter 0x478) -- ends 0x484
|
|
|
|
friend struct GaussRifleLayoutCheck;
|
|
};
|
|
|
|
struct GaussRifleLayoutCheck {
|
|
static_assert(offsetof(GaussRifle, muzzleVelocity) == 0x478, "GaussRifle::muzzleVelocity @0x478 (Emitter must end 0x478)");
|
|
static_assert(sizeof(GaussRifle) == 0x484, "sizeof(GaussRifle) 0x484 (== factory alloc)");
|
|
};
|
|
|
|
|
|
#endif
|