From 3637f5c6b1642c698ad06783c4a01b8ebf238bcc Mon Sep 17 00:00:00 2001
From: Cyd <cyd@falloutshelterarcade.com>
Date: Wed, 1 Jul 2026 00:20:33 -0500
Subject: [PATCH] install.bat: silent UltraVNC server install via custom Inno
 answer file

Install the UltraVNC server component with the service tasks selected up front
(SetupType=custom, Components=ultravnc_server, Tasks=installservice,startservice)
and run the setup with start /wait + /loadinf so the pod comes up with the VNC
service registered and started for remote diagnostics.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
---
 Launcher/assets/UltraVNC/UltraVNC.inf |  6 +++---
 Launcher/install.bat                  | 19 ++++++++++++-------
 2 files changed, 15 insertions(+), 10 deletions(-)

diff --git a/Launcher/assets/UltraVNC/UltraVNC.inf b/Launcher/assets/UltraVNC/UltraVNC.inf
index 6a2a609..5bc01b6 100644
--- a/Launcher/assets/UltraVNC/UltraVNC.inf
+++ b/Launcher/assets/UltraVNC/UltraVNC.inf
@@ -5,6 +5,6 @@ Lang=en
 Dir=C:\Program Files\uvnc bvba\UltraVNC
 Group=UltraVNC
 NoIcons=0
-SetupType=server_silent
-Components=
-Tasks=
+SetupType=custom
+Components=ultravnc_server
+Tasks=installservice,startservice
diff --git a/Launcher/install.bat b/Launcher/install.bat
index dd04c35..9cb736b 100644
--- a/Launcher/install.bat
+++ b/Launcher/install.bat
@@ -145,12 +145,17 @@ if exist "%ROOT%\openal\oalinst.exe" (
     echo       OpenAL installed.
 )
 
-:: Install UltraVNC runtime (required by for remote diagnostics)
-if exist "%ROOT%\UltraVNC\UltraVNC_x64_Setup.exe" (
+:: Install UltraVNC server (remote diagnostics). The Inno installer lays down
+:: the files and (via /loadinf) sets the install dir + VNC password; we then
+:: register and start the service EXPLICITLY with winvnc.exe. Doing the service
+:: step ourselves means a missing/incomplete "install service" task in the
+:: answer file can't leave the pod with the files present but nothing listening.
+set UVNC_SETUP=%ROOT%UltraVNC\UltraVNC_x64_Setup.exe
+set UVNC_DIR=C:\Program Files\uvnc bvba\UltraVNC
+if exist "%UVNC_SETUP%" (
     echo       Installing UltraVNC server...
-    "%ROOT%\UltraVNC\UltraVNC_x64_Setup.exe" /verysilent /norestart /loadinf="%ROOT%\UltraVNC\UltraVNC.inf"
-    echo       UltraVNC installed.
-)
+    start "" /wait "%UVNC_SETUP%" /verysilent /norestart /loadinf="%ROOT%UltraVNC\UltraVNC.inf"
+    )
 
 :: Enable SMB1 client (required by game networking)
 echo       Enabling SMB1 file sharing...
@@ -165,10 +170,10 @@ icacls "C:\mw4files" /grant *S-1-1-0:(OI)(CI)M /T >nul 2>&1
 :: Recreate shares idempotently (net share fails if the name already exists).
 net share mw4files /delete >nul 2>&1
 net share mw4files=C:\mw4files /grant:Everyone,FULL >nul 2>&1
-echo       Share \\%COMPUTERNAME%\mw4files -> C:\mw4files (Everyone: Full)
+echo       "Share \\%COMPUTERNAME%\mw4files -> C:\mw4files (Everyone: Full)"
 net share c /delete >nul 2>&1
 net share c=C:\ /grant:Everyone,FULL >nul 2>&1
-echo       Share \\%COMPUTERNAME%\c -> C:\ (Everyone: Full)
+echo       "Share \\%COMPUTERNAME%\c -> C:\ (Everyone: Full)"
 
 :: Enable DirectPlay (required by older games)
 echo       Enabling DirectPlay...