Files
firestorm/MW4COMPARE/tools/decompile/verify_damage.py
T
83478b7666 Add MW4COMPARE: .mw4 decompiler toolchain and V4H comparison harness
Tooling built to recover editable source for six 'Mech chassis that exist
in the parallel FS_Build_V4H build but not in this repo. Reverse-engineers
every compiled record type in the .mw4 package format back to the .data /
.instance / .subsystems / .damage / .contents / .torso / .engine /
.armature sources the content pipeline consumes.

Nothing here is wired into the game build. It is a standalone analysis
harness run from Linux.

Package format
--------------
"#VBD" container. Directory records are [len][name][FILETIME][origSize]
[storedSize][offset], payload base at dword 0x0C. A record is stored raw
when storedSize == origSize, otherwise LZW (9->12-bit LSB-first codes,
256=clear, 257=EOF, dict from 258), per Database.cpp:451.

GameModel records are flat /Zp4 structs following the C++ inheritance
chain Entity(0) -> Mover(28) -> MWObject(80) -> Vehicle(664) -> Mech(756),
1636 bytes total. CreateMessage records follow Replicator -> Entity ->
Mover -> MWMover -> MWObject -> Vehicle -> Mech from start=16 (the
undeclared Connection__Message header), ending at 341 and padded to 344.

tools/decompile/
----------------
  datamap.py        header-driven layout engine; CHAIN + ANCHORS
                    {Vehicle:664, Mech:756} assert the struct offsets
  mw4msg.py         CreateMessage reader/walker
  data.py           .data      constants.py  define/table symbol resolution
  damage.py         .damage    contents.py   .contents
  smallmodel.py     .torso + .engine         instance.py  .instance
  armature.py / armature_parts.py  .armature + armaturedata/armaturevideo
  assembly.py       joint hierarchy renderer
  make_generic_doll.py  builds generic MFD/Radar damage dolls
  verify_*.py       per-type round-trip verifiers

Verified round-trip across all 64 shared chassis:
  .armature      2938/2976 pages     .subsystems  7579/7585 keys
  .data map      6071/6071 values    .data trip   8291/8306 keys
  .damage        6605/6605 keys      .contents    7480/7480 keys
  .torso+.engine 1280/1280 keys      .instance     896/896 keys, 64/64 pages
  armature_parts 1202/1202 .data, 1149/1202 .video

Layout-discovery lessons (documented in DECOMPILING.md)
-------------------------------------------------------
- Never let a field map be discovered by the values that verify it. A
  value-matching pass reported 4288/4288 while mis-assigning 34 keys. The
  map was rebuilt from header declaration order, anchored on uniquely
  resolved fields.
- Read the factory, not the data. 12 .data fields and 5 Torso fields are
  declared plain Stuff::Scalar but multiplied by Radians_Per_Degree in
  Mech_Tool.cpp:889 / Torso_Tool.cpp.
- Strip typedefs before walking a header. A stray `typedef int AttributeID;`
  masked a missing ClassID - two 4-byte errors cancelling out, caught only
  by the ANCHORS assertion.
- A verifier that silently narrows its own input reports success. Braced
  blocks must be hidden before splitting pages, replacing both CR and LF,
  because a `Shadow={...}` block contains a line reading `[shadow]` and
  splitlines() also splits on bare CR.
- NSWIZZLE is undefined, so the #else branch is live and orders members
  differently. bool is 1 byte; char x[MaxStringLength] is 256.
- V4H carries stale Mech IDs (their Atlas is 5, ours 6), so 64 of 65 shared
  chassis are off by one; --retarget-ids emits $(M_<Chassis>)/$(IDS_<Chassis>).

reports/ holds generated diffs. The two ~5 MB manifest-*.tsv intermediates
are gitignored; regenerate everything with run-comparison.sh.

Co-authored-by: Claude Opus 5 (Anthropic) <noreply@anthropic.com>
Co-authored-by: GitHub Copilot <copilot@github.com>
2026-08-08 16:47:57 -05:00

126 lines
4.9 KiB
Python

#!/usr/bin/env python3
"""Round-trip verifier for the .damage decompiler.
Regenerates a whole `.damage` from the compiled record for every chassis and
compares it page by page against the authored source: page names, page order,
key sets and values.
Comparison is semantic. Sources carry an `!include` line and comments, spell
numbers freely (`.99` vs `0.99`, `1.0` vs `1`), and Windows path lookup is
case-insensitive, so none of those count as differences.
python3 verify_damage.py [--show CHASSIS]
"""
import argparse, collections, glob, os, re, sys
sys.path.insert(0, os.path.dirname(os.path.abspath(__file__)))
import damage, subsystems
REC = "/home/rich/Repositories/FS_Ours_extracted/core/mechs"
SRC = "/home/rich/Repositories/firestorm/Gameleap/mw4/Content/Mechs"
NUM = re.compile(r'^-?(?:\d+\.?\d*|\.\d+)$')
def canon(v):
v = str(v).strip()
if NUM.match(v):
return f"{float(v):.4g}"
if "," in v: # DamageEffect: path,percent
path, _, pct = v.rpartition(",")
return canon(path) + "," + (f"{float(pct):.4g}" if NUM.match(pct.strip()) else pct)
v = re.sub(r'^content[\\/]', '', v.replace("/", "\\"), flags=re.I)
return v.lower()
def source_pages(path):
"""-> [(pageName, [(key, value)])] preserving order and repeats."""
txt = open(path, "rb").read().decode("latin-1")
txt = re.sub(r'//[^\n]*', '', txt)
pages, cur = [], None
for line in txt.splitlines():
line = line.strip()
if not line or line.startswith("!"):
continue
m = re.match(r'^\[([^\]]+)\]$', line)
if m:
cur = (m.group(1), [])
pages.append(cur)
elif "=" in line and cur is not None:
k, v = line.split("=", 1)
cur[1].append((k.strip(), v.strip()))
return pages
def main():
ap = argparse.ArgumentParser()
ap.add_argument("--show")
args = ap.parse_args()
manifest = subsystems.load_manifest(damage.MANIFEST)
t = collections.Counter()
bad = collections.Counter()
examples = []
order_problems = []
for d in sorted(glob.glob(REC + "/*")):
ch = os.path.basename(d)
src = [p for p in glob.glob(SRC + "/*/*.damage")
if os.path.basename(p).lower() == ch.lower() + ".damage"]
if not src or not glob.glob(os.path.join(d, "*.damage")):
continue
t["chassis"] += 1
want = source_pages(src[0])
got = damage.decompile(d, manifest)
if args.show and args.show.lower() == ch.lower():
sys.stdout.write(damage.emit(got))
return
if [n.lower() for n, _ in want] != [n.lower() for n, _ in got]:
order_problems.append((ch, [n for n, _ in want], [n for n, _ in got]))
continue
t["pages"] += len(want)
for (wname, wkv), (_gname, gkv) in zip(want, got):
wmap = collections.defaultdict(list)
for k, v in wkv:
wmap[k.lower()].append(canon(v))
gmap = collections.defaultdict(list)
for k, v in gkv:
gmap[k.lower()].append(canon(v))
for key in set(wmap) | set(gmap):
t["keys"] += 1
w, g = sorted(wmap.get(key, [])), sorted(gmap.get(key, []))
# The writer defaults MaxArmorValue to BaseArmorValue, so a source
# that omits it and one that states it equal produce identical
# bytes -- 51 pages do state it. The distinction is unrecoverable
# and harmless, so emitting it explicitly counts as a match.
if not w and key == "maxarmorvalue" and g == sorted(gmap.get("basearmorvalue", [])):
t["ok"] += 1
t["implicit_max"] += 1
elif w == g:
t["ok"] += 1
else:
bad[key] += 1
if len(examples) < 12:
examples.append((ch, wname, key, wmap.get(key), gmap.get(key)))
print(f"chassis : {t['chassis']}")
print(f"pages compared : {t['pages']}")
print(f"keys compared : {t['keys']} exact: {t['ok']} wrong: {t['keys'] - t['ok']}")
print(f" MaxArmorValue omitted by source, implied by BaseArmorValue: {t['implicit_max']}")
if order_problems:
print(f"\npage name/order mismatches: {len(order_problems)}")
for ch, w, g in order_problems[:3]:
print(f" {ch}\n want {w}\n got {g}")
if bad:
print("\nkeys not matching:")
for k, n in bad.most_common(15):
print(f" {k:28s} x{n}")
print("\nexamples (chassis, page, key, source, decoded):")
for e in examples:
print(f" {e[0]:14s} {e[1]:22s} {e[2]:22s} {e[3]} != {e[4]}")
if __name__ == "__main__":
main()