Files
CydandClaude Opus 4.8 b3cb764f4d Phase 2: serial + RIO protocol core (RioJoy.Core) with unit tests
Port the RIO wire protocol from legacy/riovjoy2.cpp into testable C#:

- Protocol/: command + length table, 7-bit checksum, packet builder, and a
  streaming receive-side framing state machine (PacketParser) that mirrors the
  legacy ReadCommBlock framing/resync (high-bit-mid-packet abort). Typed RIO->PC
  decodes: AnalogReport (14-bit sign-extend), VersionInfo, CheckStatus; lamp-state
  composition.
- Serial/: RioSerialLink drives an async receive loop with ACK/NAK reply policy
  (legacy force-accept vs. opt-in VerifyInboundChecksum), the analog poll timer,
  and the >5s reset-recovery watchdog. IRioTransport abstracts the COM port; the
  SerialPort-backed transport does 9600 8N1 + DTR reset pulse, and acquire/release
  is just create/dispose (foundation for native-game serial yield).
- tests/RioJoy.Core.Tests: 54 xUnit tests covering checksum, framing/resync,
  builder round-trips, analog sign-extension + sentinel rejection, lamp combos,
  and the read loop driven against an in-memory fake transport.

Hardware verification (version/check/analog against a cabinet) remains; it can't
be done off-device.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-06-26 13:04:03 -05:00

47 lines
1.4 KiB
C#

using RioJoy.Core.Protocol;
using Xunit;
namespace RioJoy.Core.Tests.Protocol;
public class AnalogReportTests
{
[Theory]
[InlineData(0x00, 0x00, 0)]
[InlineData(0x7F, 0x00, 127)]
[InlineData(0x7F, 0x3F, 8191)] // max positive 13-bit value
[InlineData(0x00, 0x40, -8192)] // bit 13 set → most negative
[InlineData(0x7F, 0x7F, -1)] // all 14 bits set → -1
public void CombinePair_SignExtends14Bit(byte low, byte high, int expected)
{
Assert.Equal((short)expected, AnalogReport.CombinePair(low, high));
}
[Fact]
public void TryParse_DecodesAxesInOrder()
{
// throttle=1, left=2, right=3, Y=4, X=5 (each from a low byte, high=0)
var payload = new byte[] { 1, 0, 2, 0, 3, 0, 4, 0, 5, 0 };
Assert.True(AnalogReport.TryParse(payload, out AnalogReport r));
Assert.Equal(1, r.Throttle);
Assert.Equal(2, r.LeftPedal);
Assert.Equal(3, r.RightPedal);
Assert.Equal(4, r.JoystickY);
Assert.Equal(5, r.JoystickX);
}
[Fact]
public void TryParse_RejectsRestartSentinel()
{
// A 0xFE anywhere in the payload marks the sample invalid.
var payload = new byte[] { 1, 0, 2, 0, 0xFE, 0, 4, 0, 5, 0 };
Assert.False(AnalogReport.TryParse(payload, out _));
}
[Fact]
public void TryParse_RejectsWrongLength()
{
Assert.Throws<ArgumentException>(() => AnalogReport.TryParse(new byte[9], out _));
}
}